Skip to content

[Plan] 기존 타임라인 정렬 방식 변경#93

Merged
Creamcheesepie merged 1 commit into
mainfrom
refactor/#84
Dec 17, 2025
Merged

[Plan] 기존 타임라인 정렬 방식 변경#93
Creamcheesepie merged 1 commit into
mainfrom
refactor/#84

Conversation

@kms152000
Copy link
Copy Markdown
Collaborator

@kms152000 kms152000 commented Dec 16, 2025 •
edited
Loading

🔗 관련 이슈

#84

🚀 PR 개요

  • 기존 sequenceOrder를 이용한 타임라인 정렬을 startAt(LocalTime)으로 변경

📌 변경 사항

주요 변경 내용을 체크리스트 형태로 정리해주세요.

  • 기능 추가
  • 버그 수정
  • 리팩터링
  • 문서 업데이트
  • 테스트 추가/수정

@kms152000 kms152000 self-assigned this Dec 16, 2025
@kms152000 kms152000 changed the title [Plan] refactor: 기존 타임라인 정렬 방식 변경 [Plan] 기존 타임라인 정렬 방식 변경 Dec 16, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 16, 2025

Test Results

1 tests  ±0   1 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit b729ae7. ± Comparison against base commit 697d54e.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 16, 2025

⭐ JaCoCo Coverage

Line Coverage: 5.77%

📄 Coverage Details

Overall Line Coverage: 5.73% (119 covered / 2075 lines)

Package Summary (lowest first)
Package Line % Covered Missed
com/back/web7_9_codecrete_be/domain/chats/controller 0.00% 0 0
com/back/web7_9_codecrete_be/domain/location/service 0.00% 0 25
com/back/web7_9_codecrete_be/domain/chats/service 0.00% 0 0
com/back/web7_9_codecrete_be/domain/plans/controller 0.00% 0 33
com/back/web7_9_codecrete_be/domain/location/controller 0.00% 0 4
com/back/web7_9_codecrete_be/global/rsData 0.00% 0 11
com/back/web7_9_codecrete_be/domain/location/entity 0.00% 0 0
com/back/web7_9_codecrete_be/global/scheduler 0.00% 0 3
com/back/web7_9_codecrete_be/domain/auth/entity 0.00% 0 0
com/back/web7_9_codecrete_be/domain/auth/service 0.00% 0 71
com/back/web7_9_codecrete_be/domain/plans/service 0.00% 0 278
com/back/web7_9_codecrete_be/global/initData 0.00% 0 26
com/back/web7_9_codecrete_be/domain/users/controller 0.00% 0 20
com/back/web7_9_codecrete_be/domain/email/entity 0.00% 0 6
com/back/web7_9_codecrete_be/domain/users/service 0.00% 0 59
com/back/web7_9_codecrete_be/domain/auth/controller 0.00% 0 20
com/back/web7_9_codecrete_be/domain/concerts/controller 0.00% 0 22
com/back/web7_9_codecrete_be/domain/artists/controller 0.00% 0 12
com/back/web7_9_codecrete_be/global/aspect 0.00% 0 4
com/back/web7_9_codecrete_be/global/wikidata 0.36% 1 279
com/back/web7_9_codecrete_be/domain/artists/service 0.86% 3 345
com/back/web7_9_codecrete_be/global/musicbrainz 0.99% 1 100
com/back/web7_9_codecrete_be/domain/email/service 1.92% 1 51
com/back/web7_9_codecrete_be/domain/concerts/entity 4.76% 3 60
com/back/web7_9_codecrete_be/domain/concerts/service 6.80% 21 288
com/back/web7_9_codecrete_be/domain/artists/entity 9.09% 3 30
com/back/web7_9_codecrete_be/global/rq 12.90% 4 27
com/back/web7_9_codecrete_be/domain/users/entity 22.86% 8 27
com/back/web7_9_codecrete_be/domain/plans/entity 25.00% 21 63
com/back/web7_9_codecrete_be/global/security 26.36% 29 81
com/back/web7_9_codecrete_be/global/storage 33.33% 1 2
com/back/web7_9_codecrete_be/global/spotify 35.71% 5 9
com/back/web7_9_codecrete_be/domain/chats/entity 100.00% 1 0
com/back/web7_9_codecrete_be/global/doc 100.00% 17 0
Lowest Covered Classes (Top 20)
Class Line % Covered Missed
com.back.web7_9_codecrete_be.domain.plans.service.PlanService 0.00% 0 278
com.back.web7_9_codecrete_be.domain.users.service.UserService 0.00% 0 55
com.back.web7_9_codecrete_be.domain.concerts.service.ConcertService 0.00% 0 48
com.back.web7_9_codecrete_be.domain.auth.service.AuthService 0.00% 0 44
com.back.web7_9_codecrete_be.domain.artists.service.ArtistService 0.00% 0 44
com.back.web7_9_codecrete_be.domain.concerts.entity.Concert 0.00% 0 38
com.back.web7_9_codecrete_be.global.security.JwtTokenProvider 0.00% 0 37
com.back.web7_9_codecrete_be.domain.plans.entity.Schedule 0.00% 0 34
com.back.web7_9_codecrete_be.domain.plans.controller.PlanController 0.00% 0 33
com.back.web7_9_codecrete_be.domain.users.entity.User 0.00% 0 27
com.back.web7_9_codecrete_be.domain.auth.service.TokenService 0.00% 0 27
com.back.web7_9_codecrete_be.global.initData.BaseInitData 0.00% 0 26
com.back.web7_9_codecrete_be.domain.artists.entity.Artist 0.00% 0 25
com.back.web7_9_codecrete_be.domain.users.controller.UserController 0.00% 0 20
com.back.web7_9_codecrete_be.domain.auth.controller.AuthController 0.00% 0 20
com.back.web7_9_codecrete_be.domain.plans.entity.Plan 0.00% 0 18
com.back.web7_9_codecrete_be.domain.concerts.controller.ConcertController 0.00% 0 14
com.back.web7_9_codecrete_be.domain.location.service.TmapService 0.00% 0 13
com.back.web7_9_codecrete_be.domain.concerts.service.KopisApiService$TicketPrice 0.00% 0 13
com.back.web7_9_codecrete_be.domain.location.service.KakaoLocalService 0.00% 0 12
Changed Classes (from this PR)
Source (PR) Class Prefix Line % Covered Missed
src/main/java/com/back/web7_9_codecrete_be/domain/plans/service/PlanService.java com.back.web7_9_codecrete_be.domain.plans.service.PlanService 0.00% 0 278
src/main/java/com/back/web7_9_codecrete_be/domain/plans/dto/request/ScheduleAddRequest.java com.back.web7_9_codecrete_be.domain.plans.dto.request.ScheduleAddRequest 0.00% 0 0
src/main/java/com/back/web7_9_codecrete_be/domain/plans/dto/request/ScheduleUpdateRequest.java com.back.web7_9_codecrete_be.domain.plans.dto.request.ScheduleUpdateRequest 0.00% 0 0
src/main/java/com/back/web7_9_codecrete_be/domain/plans/dto/response/PlanDetailResponse.java com.back.web7_9_codecrete_be.domain.plans.dto.response.PlanDetailResponse 0.00% 0 0
src/main/java/com/back/web7_9_codecrete_be/domain/plans/dto/response/ScheduleResponse.java com.back.web7_9_codecrete_be.domain.plans.dto.response.ScheduleResponse 0.00% 0 0
src/main/java/com/back/web7_9_codecrete_be/domain/plans/repository/ScheduleRepository.java com.back.web7_9_codecrete_be.domain.plans.repository.ScheduleRepository 0.00% 0 0
src/main/java/com/back/web7_9_codecrete_be/domain/plans/entity/Schedule.java com.back.web7_9_codecrete_be.domain.plans.entity.Schedule 22.73% 10 34

🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE/actions/runs/20257684561

ys0221
ys0221 approved these changes Dec 16, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ys0221 ys0221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

Creamcheesepie
Creamcheesepie approved these changes Dec 16, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Creamcheesepie Creamcheesepie left a comment •
edited by kms152000
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일정 시간이 중복되는 경우에 예외 처리를 한다거나 하는 부분이 있을까요?

@Creamcheesepie 중복되는 일정이 있는 경우 보조 정렬로 createdTime으로 정렬하는 방법을 생각했었지만 겹치는 일정은 어떻게 정렬돼도 의미 없을 거 같아 예외처리는 하지 않았습니다!

larama-C
larama-C approved these changes Dec 16, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@larama-C larama-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 이렇게 보니까 localtime이 좀 더 적절해보이긴 하네요!

tobbot16
tobbot16 approved these changes Dec 16, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tobbot16 tobbot16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

@Creamcheesepie Creamcheesepie merged commit eb8fb5c into main Dec 17, 2025
2 checks passed
@Creamcheesepie Creamcheesepie deleted the refactor/#84 branch December 17, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobbot16 tobbot16 tobbot16 approved these changes

@larama-C larama-C larama-C approved these changes

@Creamcheesepie Creamcheesepie Creamcheesepie approved these changes

@ys0221 ys0221 ys0221 approved these changes

Assignees

@kms152000 kms152000

Labels

Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Plan] 타임라인 조회 기능 변경

5 participants

@kms152000 @tobbot16 @larama-C @Creamcheesepie @ys0221